Skip to content

chore(samples): add sample for AddToCell mutation#1285

Open
daniel-sanche wants to merge 17 commits intomainfrom
add-increment-sample
Open

chore(samples): add sample for AddToCell mutation#1285
daniel-sanche wants to merge 17 commits intomainfrom
add-increment-sample

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Jan 30, 2026

Replaces #1231
Fixes b/452032333

Adds a sample for the new AddToCell incrementation mutation

@daniel-sanche daniel-sanche requested review from a team as code owners January 30, 2026 22:43
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 30, 2026
@snippet-bot
Copy link

snippet-bot bot commented Jan 30, 2026 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Jan 30, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new asynchronous code sample for Google Cloud Bigtable, demonstrating the use of the AddToCell mutation to increment values within a table. This enhancement provides developers with a clear example of how to leverage Bigtable's aggregation capabilities, ensuring proper setup of aggregate column families and robust error handling. The accompanying test updates validate the new sample's functionality, improving the overall coverage and utility of the Bigtable client library examples.

Highlights

  • New AddToCell Mutation Sample: A new asynchronous sample, write_aggregate, has been added to demonstrate how to use the AddToCell mutation to increment values in a Bigtable table. This includes proper setup for aggregate column families and error handling.
  • Test Suite Enhancements for Aggregation: The test suite now includes a new column_family_config fixture to define an aggregate column family (counters) with an int64 input type, which is essential for AddToCell mutations. The table_id fixture was updated to use this configuration.
  • New Asynchronous Test: A new asynchronous test, test_write_aggregate, has been added to validate the functionality of the newly introduced write_aggregate sample.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 30, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new sample for the AddToCell mutation. I've identified a critical issue in the sample code where a required argument is missing, which will lead to a TypeError. Additionally, I found a syntax error and another minor issue in the test file. My review includes suggestions to fix these problems.

@daniel-sanche daniel-sanche mentioned this pull request Jan 30, 2026
Closed
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2026
KasiaStrz
KasiaStrz reviewed Feb 3, 2026
View reviewed changes
samples/snippets/data_client/data_client_snippets_async.py
family="counters",
qualifier="odometer",
value=32304,
timestamp_micros=time.time_ns() // 1000,
Copy link

@KasiaStrz KasiaStrz Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to # Convert nanoseconds to microseconds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsamborski rsamborski Awaiting requested review from rsamborski rsamborski is a code owner automatically assigned from googleapis/python-samples-reviewers

2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@KasiaStrz KasiaStrz KasiaStrz approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@kongweihan kongweihan

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daniel-sanche @KasiaStrz @kongweihan @yoshi-kokoro